Skip to content

ci(asyncio): skip asyncio not imported test#18586

Open
brettlangdon wants to merge 1 commit into
mainfrom
brettlangdon/fix.lazyimport.test
Open

ci(asyncio): skip asyncio not imported test#18586
brettlangdon wants to merge 1 commit into
mainfrom
brettlangdon/fix.lazyimport.test

Conversation

@brettlangdon

@brettlangdon brettlangdon commented Jun 11, 2026

Copy link
Copy Markdown
Member

Description

This test has started failing recently. Previously it was quarantined.

This test is now failing because wrapt>=2 now imports asyncio by default, and we have some default code paths which rely on importing wrapt.

At this time, the following modules import wrapt with import ddtrace.auto:

  • ddtrace.internal.forksafe
  • ddtrace.internal.compat
  • ddtrace.internal.safety
  • ddtrace.vendor.debtcollector.moves
  • ddtrace.vendor.debtcollector.removals
  • ddtrace.vendor.debtcollector.renames
  • ddtrace.vendor.debtcollector.updating
  • ddtrace._trace.trace_handlers
  • ddtrace.contrib.internal.trace_utils

Testing

Risks

Additional Notes

@brettlangdon brettlangdon requested review from a team as code owners June 11, 2026 10:56
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 11, 2026
@brettlangdon brettlangdon requested a review from wantsui June 11, 2026 10:56
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jun 11, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d0e03da60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/contrib/asyncio/test_lazyimport.py
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jun 11, 2026 •
edited by datadog-datadog-prod-us1 Bot
Loading

Copy link
Copy Markdown
Contributor

Pipelines  Tests

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 8 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64, 1]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741491-d2b8243-musllinux_1_2_x86_64, 1]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741357-d2b8243-manylinux2014_aarch64, 1]   View in Datadog   GitLab

View all 8 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 1 test - 1 passed on retry View in Datadog

🚧 25 tests that failed were ignored due to quarantine View in Datadog

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1d0e03d | Docs | Datadog PR Page | Give us feedback!

@pr-commenter

pr-commenter Bot commented Jun 11, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-06-11 11:19:37

Comparing candidate commit 1d0e03d in PR branch brettlangdon/fix.lazyimport.test with baseline commit 1a5569d in branch main.

Found 0 performance improvements and 5 performance regressions! Performance is the same for 616 metrics, 10 unstable metrics.

scenario:iast_aspects-re_expand_aspect

  • 🟥 execution_time [+255.964µs; +303.622µs] or [+7.151%; +8.483%]

scenario:iastaspects-strip_noaspect

  • 🟥 execution_time [+24.698µs; +29.706µs] or [+11.065%; +13.309%]

scenario:iastaspects-upper_aspect

  • 🟥 execution_time [+35.598µs; +45.041µs] or [+11.544%; +14.607%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+103.673µs; +113.359µs] or [+24.556%; +26.850%]

scenario:span-start

  • 🟥 execution_time [+1.278ms; +1.445ms] or [+8.296%; +9.381%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@emmettbutler emmettbutler Awaiting requested review from emmettbutler emmettbutler is a code owner automatically assigned from DataDog/apm-core-python

@wantsui wantsui Awaiting requested review from wantsui wantsui is a code owner automatically assigned from DataDog/apm-idm-python

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@brettlangdon